Ownership selection in VPC tiers and VPC public IPs by gp-santos · Pull Request #9692 · apache/cloudstack

gp-santos · 2024-09-16T17:20:25Z

Description

This PR adds the "ownership selection" UI fields to VPC tiers and VPC public IPs.

The "vpcAccess" response attribute was added so the UI can know if the caller has access to the VPC without needing to make a whole new request. This is needed to avoid 404 links (since router.resolve is assembled through API permissions) and so the UI can present the correct public IPs to their possible network tiers (e.g. if the User has tiers of two different VPCs, they can't use one's public IP in the other).

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

New tier possible owners' listing

Tier listing

User accessing their tier of the Admin's VPC

Possible owners for new IP

How Has This Been Tested?

Environment with domains Root (with accounts Root Admin and User), Root/1 (with a Domain Admin), Root/A (with a Domain Admin) and Root/A/B (with a Domain Admin and a User). There is a Project in each domain, owned by the respective admins.

Situation	Test
As Root Admin with VPC owned by self.	Every account and project listed as possible owners in Tier creation
As Root Admin with VPC owned by self and one tier for each account and project.	Every account and project listed as possible owners in acquiring public IP.
Same as previous, but remove some of the tiers.	The deleted tiers' owners also disappeared from IP possible owners' list, except Root Admin itself.
As Root Admin with VPC owned by self, create one tier with a private ACL for the User.	User's access to network page did not present the 'ACL' attribute.
As Root Admin with VPC owned by self, create one tier with a global ACL for the User.	User's access to network page showed 'ACL' attribute.

How did you try to break this feature and the system with this change?

codecov · 2024-09-16T17:28:53Z

Codecov Report

❌ Patch coverage is 75.00000% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.09%. Comparing base (5893ba5) to head (bc106fd).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...che/cloudstack/api/response/IPAddressResponse.java	0.00%	3 Missing ⚠️
...pache/cloudstack/api/response/NetworkResponse.java	50.00%	3 Missing ⚠️
...src/main/java/com/cloud/api/ApiResponseHelper.java	90.00%	3 Missing ⚠️
...tack/api/command/user/network/ListNetworksCmd.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #9692   +/-   ##
=========================================
  Coverage     18.09%   18.09%           
- Complexity    16723    16725    +2     
=========================================
  Files          6037     6037           
  Lines        542580   542671   +91     
  Branches      66427    66451   +24     
=========================================
+ Hits          98155    98179   +24     
- Misses       433399   433465   +66     
- Partials      11026    11027    +1

Flag	Coverage Δ
uitests	`3.51% <ø> (-0.01%)`	⬇️
unittests	`19.25% <75.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sureshanaparti · 2024-09-20T12:16:12Z

@blueorangutan package

blueorangutan · 2024-09-20T12:18:06Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-20T13:22:58Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11164

github-actions · 2025-04-09T11:49:32Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

JoaoJandre · 2025-06-02T20:04:02Z

@gpordeus could you fix the conflicts?

rajujith · 2026-01-13T05:29:33Z

@gpordeus Since this is for the 4.22.1 release, could you retarget the PR to the 4.22 branch?

Co-authored-by: Fabricio Duarte <fabricio.duarte.jr@gmail.com>

gp-santos · 2026-05-19T19:08:34Z

Hi, @rajujith, @sureshanaparti, @JoaoJandre and @winterhazel

Sorry for taking so long on getting back to this, it had been a while since I made this and the conflicts with 4.22 threw me for a loop.

I fixed the conflicts with the main branch and I fixed the instance listing when the tier belongs to a project.

Could you take another look?

sureshanaparti · 2026-05-19T19:14:41Z

@blueorangutan package

blueorangutan · 2026-05-19T19:16:05Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-05-19T19:56:17Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17914

boring-cyborg Bot added component:api component:networking component:UI labels Sep 16, 2024

gp-santos added this to the 4.21.0.0 milestone Sep 16, 2024

winterhazel reviewed Jan 24, 2025

View reviewed changes

github-actions Bot added the status:has-conflicts label Apr 9, 2025

sureshanaparti added this to Apache CloudStack 4.21.0 Jun 5, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Jun 5, 2025

sureshanaparti requested a review from weizhouapache June 5, 2025 09:50

weizhouapache modified the milestones: 4.21.0, 4.22.0 Aug 29, 2025

sureshanaparti removed this from Apache CloudStack 4.21.0 Aug 29, 2025

sureshanaparti added this to Apache CloudStack 4.22.0 Aug 29, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.22.0 Aug 29, 2025

DaanHoogland marked this pull request as draft October 10, 2025 09:57

harikrishna-patnala modified the milestones: 4.22.0, 4.22.1 Nov 12, 2025

harikrishna-patnala removed this from Apache CloudStack 4.22.0 Nov 12, 2025

rajujith added this to Apache CloudStack 4.22.1 Jan 5, 2026

sureshanaparti moved this to In Progress in Apache CloudStack 4.22.1 Jan 7, 2026

sureshanaparti removed this from Apache CloudStack 4.22.1 Apr 24, 2026

sureshanaparti modified the milestones: 4.22.1, 4.23.0 Apr 24, 2026

gp-santos and others added 7 commits May 18, 2026 18:45

rebase

8b0cd2c

add tier's account to listing

732fe97

add acl response check

6fcbd14

cleanup random change

2ec2ad0

add tests

a8be0aa

Apply suggestions from code review

380f6b2

Co-authored-by: Fabricio Duarte <fabricio.duarte.jr@gmail.com>

rebase

369984b

gp-santos force-pushed the main-vpc-tier-and-ip-ownership-selection branch from 68a3bfe to 369984b Compare May 18, 2026 21:45

github-actions Bot removed the status:has-conflicts label May 19, 2026

end rebase and adjust list project vms of tier

bc106fd

gp-santos marked this pull request as ready for review May 19, 2026 19:09

Conversation

gp-santos commented Sep 16, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov Bot commented Sep 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sureshanaparti commented Sep 20, 2024

Uh oh!

blueorangutan commented Sep 20, 2024

Uh oh!

blueorangutan commented Sep 20, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 9, 2025

Uh oh!

JoaoJandre commented Jun 2, 2025

Uh oh!

rajujith commented Jan 13, 2026

Uh oh!

gp-santos commented May 19, 2026

Uh oh!

sureshanaparti commented May 19, 2026

Uh oh!

blueorangutan commented May 19, 2026

Uh oh!

blueorangutan commented May 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

codecov Bot commented Sep 16, 2024 •

edited

Loading